Am 28/08/2023 um 17:54 schrieb Maximiliano Sandoval:
> Signed-off-by: Maximiliano Sandoval <[email protected]>
> ---
> xgettext supports extracting comments so I added a comment to make it future
> proof. Note though our tooling (proxmox-i18n) strips them. I hope to send a
> patch fixing
> this soon.
>
> Differences from v1:
> - Use format instead of relying on a translator comment.
>
> www/manager6/ceph/OSD.js | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js
> index d2caafa4..242674fb 100644
> --- a/www/manager6/ceph/OSD.js
> +++ b/www/manager6/ceph/OSD.js
> @@ -233,7 +233,8 @@ Ext.define('PVE.CephSetFlags', {
>
> onlineHelp: 'pve_ceph_osds',
> isCreate: true,
> - title: Ext.String.format(gettext('Manage {0}'), 'Global OSD Flags'),
> + // TRANSLATORS: This will read 'Manage Global OSD Flags'.
> + title: Ext.String.format(gettext('Manage Global {0} Flags'), 'OSD'),
Hmm, not sure how often this will be reused where {0} will be replaced with
something else. I'd rather prefer one of:
- Ext.String.format(gettext('Manage {0}'), gettext('Global OSD Flags')),
"Manage XYZ" is relatively common, so we might have more reuse potential.
- gettext('Manage Global OSD Flags')
Fine too, as IMO this is rather specific anyway and unlikely that we have
many others where a parametrized msgstr is really reducing translation
effort.
what do you think?
_______________________________________________
pve-devel mailing list
[email protected]
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
