On 21/08/2023 10:33, Fiona Ebner wrote: > Would it make sense to instead add a constant multiplier to the memory > timeout heuristic in presence of PCI passthrough? The user says 65 GiB > takes about 3 min 30 s, so assuming it's more or less linear, the 5 min > from this patch would not be enough for more than ~130 GiB of memory.
You're right, a heuristic makes more sense here than a constant multiplier. I'll give it a try in the next version. >> Notes: >> An alternative workaround is offered by an unapplied patch series [3] >> of bug #3502 [2] that makes it possible to set VM-specific timeouts >> (also in the GUI). Users could use this option to manually set a >> higher timeout for VMs that use PCI passthrough. However, it is not >> immediately obvious that a higher timeout is necessary. Since the >> problem seems to come up somewhat frequently, I think it makes sense >> to have the heuristic choose a higher timeout by default. >> >> [2]: https://bugzilla.proxmox.com/show_bug.cgi?id=3502 >> [3]: >> https://lists.proxmox.com/pipermail/pve-devel/2023-January/055352.html > > Yes, I think having both the better heuristic and the configurable > timeout makes sense. Since Daniel left, do you want to have another look > at the series/pick it up? Sure! When I'm back from vacation, I'll send another version of this patch series and also take a look at Daniel's old patch series. I'll probably send them separately though, as they are somewhat independent. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
