Am 13/10/2023 um 15:50 schrieb Filip Schauer: > Fix races with ACPI-suspended VMs which could wake up during migration > or during a suspend-mode backup. > > Revert prevention, of ACPI-suspended VMs automatically resuming after > migration, introduced by 7ba974a6828d. The commit introduced a potential > problem that causes a suspended VM that wakes up during migration to > remain paused after the migration finishes. > > Furthermore the commit increased the race window during the preparation > of a suspend-mode backup, when a suspended VM wakes up between the > vm_is_paused check in PVE::VZDump::QemuServer::prepare and > PVE::VZDump::QemuServer::qga_fs_freeze. This causes the code to skip > fs-freeze even if the VM has woken up, potentially leaving the file > system in an inconsistent state. > > To prevent this, do not treat the suspended runstate as paused when > migrating or archiving a VM. > > Signed-off-by: Filip Schauer <f.scha...@proxmox.com> > --- > PVE/API2/Qemu.pm | 4 ++-- > PVE/QemuMigrate.pm | 4 +++- > PVE/QemuServer.pm | 6 +++--- > PVE/VZDump/QemuServer.pm | 4 +++- > 4 files changed, 11 insertions(+), 7 deletions(-) > >
applied, with Fiona's R-b and extra info massaged into the commit message, thanks! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
