Am 25/10/2023 um 13:09 schrieb Dominik Csapak: > in the general tab in the advanced section. > > For that to work, we introduce a new option for the TagEditContainer > named 'editOnly', which controls now the cancel/finish buttons, > automatically enter edit mode and disable enter/escape keypresses. > > We also prevent now the loading of tags while in edit mode, so the tags > don't change while editing (this can be jarring and unexpected). > > Then we wrap that all in a FieldSet that implements the Field mixin, so > we can easily use that in the wizard. There we set a maxHeight so that > the field can grow so that it still fits in the wizard. > > To properly align the input with the '+' button, we have to add a custom > css class there. (In the hbox we could set the alignment, but this is > not possible in the 'column' layout) > > Signed-off-by: Dominik Csapak <d.csa...@proxmox.com> > --- > changes from v1: > * rebase on master > * drop unnecessary/applied patches > * wrap the tagedit in a fieldset to better emphasize that its an > (unconventional) field, and move the submit logic there, keeping > the wizard a bit cleaner > > www/css/ext6-pve.css | 5 +++ > www/manager6/Makefile | 1 + > www/manager6/form/TagEdit.js | 35 +++++++++++++++-- > www/manager6/form/TagFieldSet.js | 64 +++++++++++++++++++++++++++++++ > www/manager6/lxc/CreateWizard.js | 7 ++++ > www/manager6/qemu/CreateWizard.js | 9 +++++ > 6 files changed, 117 insertions(+), 4 deletions(-) > create mode 100644 www/manager6/form/TagFieldSet.js > >
applied, thanks! Albeit it might look slightly better if docked to bottom, but it's in the advanced view anyway, and most user won't care about some slight layout difference. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
