Hi, I think it could be improve with checking that we don't have overlapping ranges in a subnet, like
range=start=192.168.0.10,end=192.168.0.20 range=start=192.168.0.15,end=192.168.0.25 I'm 100% sure it'll break with netbox ipam. -------- Message initial -------- De: Thomas Lamprecht <t.lampre...@proxmox.com> Répondre à: Proxmox VE development discussion <pve- de...@lists.proxmox.com> À: Stefan Lendl <s.le...@proxmox.com>, PVE development discussion <pve- de...@pve.proxmox.com> Cc: Proxmox Backup Server development discussion <pbs- de...@lists.proxmox.com> Objet: [pve-devel] applied: [pbs-devel] [PATCH pve-network] sdn: validate dhcp-range in API Date: 22/11/2023 14:39:20 Am 22/11/2023 um 14:00 schrieb Stefan Lendl: > * start- and end-addresses must be valid IPs > * must both be in the subnet's CIDR > * and start needs to smaller (or equal) to end > > Signed-off-by: Stefan Lendl <s.le...@proxmox.com> > --- > src/PVE/Network/SDN/SubnetPlugin.pm | 28 > ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > applied, thanks! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://antiphishing.cetsi.fr/proxy/v3?i=WjB4M1dJWGJJMnNGTHV5MuAPDwEdQk o7KGyaWIIeme0&r=Skk2OVhvdXl2cm1uOWJtRKZXDrAi7oKVS1onnLf- _Wczd58Jf89GqHNsiUfzdlXTIlsgAbazPx- o0Y0wd8PLxg&f=M2FwZHlGNnU1aUlkc09ZNNuAtV8OGeBQmVUOSCMxZYi0WAdbSPQQhYaGw WCxSpDL_rpYEExEcQs0YHFUT9yrXQ&u=https%3A//lists.proxmox.com/cgi- bin/mailman/listinfo/pve-devel&k=CXOq _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
