translating ACME does not make sense to me since it's the name of the protocol and stands for Automatic Certificate Management Environment
i don't think/believe this should be translated into other languages as a standalone word rest looks fine to me though On 11/29/23 14:21, Maximiliano Sandoval wrote:
Note that ACME is already in 3 translatable strings, a similar remark applies to N/A which is already translated in many languages. Signed-off-by: Maximiliano Sandoval <m.sando...@proxmox.com> --- src/node/DNSView.js | 2 +- src/panel/ACMEDomains.js | 2 +- src/panel/DiskList.js | 6 +++--- src/window/NotificationMatcherEdit.js | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/node/DNSView.js b/src/node/DNSView.js index 4782f9c..d2a784f 100644 --- a/src/node/DNSView.js +++ b/src/node/DNSView.js @@ -21,7 +21,7 @@ Ext.define('Proxmox.node.DNSView', { run_editor: run_editor, rows: { search: { - header: 'Search domain', + header: gettext('Search domain'), required: true, renderer: Ext.htmlEncode, }, diff --git a/src/panel/ACMEDomains.js b/src/panel/ACMEDomains.js index a7fb088..9e2e34b 100644 --- a/src/panel/ACMEDomains.js +++ b/src/panel/ACMEDomains.js @@ -10,7 +10,7 @@ Ext.define('Proxmox.panel.ACMEDomains', { mixins: ['Proxmox.Mixin.CBind'],margin: '10 0 0 0',- title: 'ACME', + title: gettext('ACME'),emptyText: gettext('No Domains configured'), diff --git a/src/panel/DiskList.js b/src/panel/DiskList.jsindex 4808f5c..dc10ac5 100644 --- a/src/panel/DiskList.js +++ b/src/panel/DiskList.js @@ -325,14 +325,14 @@ Ext.define('Proxmox.DiskList', { dataIndex: 'status', }, { - header: 'Mounted', + header: gettext('Mounted'), width: 60, align: 'right', renderer: Proxmox.Utils.format_boolean, dataIndex: 'mounted', }, { - header: 'Wearout', + header: gettext('Wearout'), width: 90, sortable: true, align: 'right', @@ -341,7 +341,7 @@ Ext.define('Proxmox.DiskList', { if (Ext.isNumeric(value)) { return (100 - value).toString() + '%'; } - return 'N/A'; + return gettext('N/A'); }, }, ], diff --git a/src/window/NotificationMatcherEdit.js b/src/window/NotificationMatcherEdit.js index f88576a..e717ad7 100644 --- a/src/window/NotificationMatcherEdit.js +++ b/src/window/NotificationMatcherEdit.js @@ -1025,7 +1025,7 @@ Ext.define('Proxmox.panel.NotificationMatchRuleSettings', { ], }, { - fieldLabel: 'Match Type', + fieldLabel: gettext('Match Type'), xtype: 'proxmoxKVComboBox', reference: 'type', isFormField: false,
_______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
