> >>From a quick look, I didn't find an option to pass along QEMU for >>this, >>so it would likely need to be implemented first/discussed with >>upstream. >>But thinking about it a bit, it feels wrong for each application to >>be >>responsible for raising the limit itself. Sure the application needs >>to >>avoid using select(), but IMHO such limits are better set from the >>outside. >>I think your approach is fine, can you please send a v2 with a >>Signed-off-by and my nits addressed?
yes, sure ! I'll send a patch this afternoon. >>I mean, ideally select() would just change to allow getting rid of >>the >>low default limit, but the man page says it won't, so ¯\_(ツ)_/¯: Yes, I was thinking the same ^_^ > WARNING: select() can monitor only file descriptors numbers > that are less than FD_SETSIZE (1024)—an unreasonably low limit for > many modern applications—and this limitation will not change. > All modern applications should instead use poll(2) or epoll(7), > which do not suffer this limitation. _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
