On October 4, 2023 9:35 am, Fiona Ebner wrote: > It's not clear to users what this property does otherwise. Latest > report from the community forum: > > https://forum.proxmox.com/threads/134393 > > Signed-off-by: Fiona Ebner <[email protected]> > --- > src/PVE/Storage/Plugin.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm > index 815773b..dc89d13 100644 > --- a/src/PVE/Storage/Plugin.pm > +++ b/src/PVE/Storage/Plugin.pm > @@ -167,7 +167,9 @@ my $defaultData = { > default => "Unlimited for users with Datastore.Allocate privilege, > 5 for other users", > }, > shared => { > - description => "Mark storage as shared.", > + description => "Indicate that this is a single storage which is > already accessible by " > + ."all nodes (or all listed in the 'nodes' option). Will not > make a local storage " > + ."automatically accessible to other nodes!",
I am not sure the 'already' helps here if you don't already (heh) know what 'shared' means. it also doesn't include that it means the same contents on all nodes - a local storage is also accessible on all nodes (or those listed in the 'nodes' option) after all, but it's not shared/has different contents on each node ;) maybe something like Indicate that this storage has the same content on all nodes that can access it. It will not automatically make a local storage shared, it just marks already shared storages as such! ? there's also content in pve-docs that would need to be harmonized after such a change, e.g. the "common storage properties", but maybe also other parts of pvesm.adoc > type => 'boolean', > optional => 1, > }, > -- > 2.39.2 > > > > _______________________________________________ > pve-devel mailing list > [email protected] > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > > _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
