I feel like this patch should be squashed into the last one, because the
checks are an essential part of the feature and they always should be
applied together anyways.

Am 08.11.23 um 09:52 schrieb Markus Frank:
> +my sub check_vm_create_dir_perm {
> +    my ($rpcenv, $authuser, $vmid, $pool, $param) = @_;
> +
> +    return 1 if $authuser eq 'root@pam';
> +
> +    foreach my $opt (keys %{$param}) {

Style nit: please use "for"

Looks good to me otherwise :)


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to