did some tests on my local machine with the `device-info` and
`device-match` subcommands to list and match against identifiers of
disks and my NIC.
Thanks for taking the time to improve this code.
consider this series:
Reviewed-By: Aaron Lauterer <a.laute...@proxmox.com>
Tested-By: Aaron Lauterer <a.laute...@proxmox.com>
On 2024-05-13 11:49, Christoph Heiss wrote:
The proxmox-auto-install-assistant uses
- glob patterns for disk matching, which can be pre-compiled for
efficiency
- regexes for udev property matching, which can be simplified by some
simple prefix matching & splitting on =
The latter also significantly reduces binary size due to the removing
the regex dependency, for details see patch #4.
Overall no functional changes in this series.
v1: https://lists.proxmox.com/pipermail/pve-devel/2024-May/063802.html
Changes v1 -> v2:
* rebased on latest master
Christoph Heiss (4):
tree-wide: run rustfmt, fix clippy warnings
assistant: drop unused `log` dependency
assistant: pre-compile ignored block device patterns
assistant: avoid regex for simple prefix matching
proxmox-auto-install-assistant/Cargo.toml | 2 -
proxmox-auto-install-assistant/src/main.rs | 75 ++++++++-----------
proxmox-auto-installer/tests/parse-answer.rs | 14 ++--
.../src/fetch_plugins/partition.rs | 10 +--
4 files changed, 45 insertions(+), 56 deletions(-)
--
2.44.0
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
