On 11/19/24 10:39, Thomas Lamprecht wrote:
Am 19.11.24 um 10:36 schrieb Dominik Csapak:
On 11/19/24 10:30, Thomas Lamprecht wrote:
Am 19.11.24 um 10:22 schrieb Dominik Csapak:
which defaults to expand all, and only if all expanded, collapse all.

Changes icon dynamically when nodes expand/collapse.

Signed-off-by: Dominik Csapak <d.csa...@proxmox.com>
---
if we'd find an icon that would fit for both cases, we could omit the
event bubbling probably. If there are many nodes, the 'hasCollapsed'
check will trigger more often, iterating over all tree nodes..

We could also just do two separate buttons, FWIW.

true, but the space there is already a bit limited IMO, and

it's just two icons and the view selector is mostly empty space as the entries
are all relatively short

only one of the buttons makes sense at one point in time


That's not completely true, if I got a few nodes expanded and a few nodes
closed then having both allows to avoid an extra click and some potential UX
confusion.

true, i'll send a v2 with two buttons, icons are ok for you or do you have a 
different
sugggestion?


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to