Am 25.11.24 um 18:04 schrieb Stefan Hanreich: > pve-firewall lowercases the names of aliases when reading from the > configuration as well as when comparing source / destination entries > with the entries in the parsed aliases. In order to stay > backwards-compatible we also need to lowercase any parsed alias name. > I decided to this in the constructor and switch all call sites to the > new constructor, so there's only one place where we have to handle > lowercasing the string. > > Signed-off-by: Stefan Hanreich <[email protected]> > --- > > Changes from v1 to v2: > * fix typo and improve description in documentation of Alias > * add bugzilla issue # to commit msg > > Also leaving the thoughts I posted under v1 here: > > Leo supplied a patch already [1] that changes the handling of names in > the firewall. Might make sense to revisit this patch series in the > future to unify how cases are handled in the firewall. Nevertheless, > this patch acts as a quick fix for users running into issues with the > firewall due to the difference in handling cases in pve-firewall and > proxmox-firewall. > > [1] https://lists.proxmox.com/pipermail/pve-devel/2023-January/055596.html > > > proxmox-ve-config/src/firewall/types/alias.rs | 49 ++++++++++++++----- > 1 file changed, 38 insertions(+), 11 deletions(-) > >
applied, thanks! _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
