Am 02.12.24 um 14:32 schrieb Lukas Wagner: > It has been a full year now, so I'd argue it is safe to drop these > safety guards now. On the off chance that there are still systems out > there which still have these entries in their notifications.cfg, > a manual removal from the file will be needed after this commit.
It be safer to argue versions not time here, as users simply can not upgrade a system for over a year and then run into such things, if the boundary is a major version OTOH they cannot run into this by just upgrading, and we could add a safety check to the future pve8to9 upgrade checker script. But, it indeed seems a bit unlikely to trigger frequently in practice, so as middleground we could add a simple detection heuristic to d/postinst and if an old-style notification is detected print a big notice about how one can fix this manually or try to rename the config file to notifications.cfg.old or the like, as we basically can never have the legacy and new stuff mixed IIRC. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
