On 04.12.2024 10:25, Dominik Csapak wrote:
high level comments/questions (i know they're not you're patches exactly, but
still):
* maybe it would be better to integrate this into the AgentIPView for vms?
AFAICS the code is very similar and probably just needs a few adaptions
to work there too (url,parsing, etc.)
I'm not opposed to have two components, but then we should at least have
a good reason in the commit message why this was not done, e.g.
the data structures are too different, or something like that
* IMHO we should keep the columns consistent between VMs and Containers,
So either we change the AgentIPView to name/mac/ipv4/ipv6 too
or we combine the ipv4/ipv6 here
Oh, and yes I combined ipv4 and ipv6 here + aligned the popup to be
more similar to the AgentView.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
