> Fiona Ebner <f.eb...@proxmox.com> hat am 12.12.2024 11:16 CET geschrieben:
>
> Am 12.12.24 um 10:54 schrieb Fabian Grünbichler:
> > when creating new ones, we already force raw as format, but adding existing
> > volumes as tpmstate0 had no such checks.
> >
> > Suggested-by: Fiona Ebner <f.eb...@proxmox.com>
> > Signed-off-by: Fabian Grünbichler <f.gruenbich...@proxmox.com>
> > ---
> > PVE/API2/Qemu.pm | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
> > index c00f60d7..fd2d0747 100644
> > --- a/PVE/API2/Qemu.pm
> > +++ b/PVE/API2/Qemu.pm
> > @@ -589,6 +589,8 @@ my sub create_disks : prototype($$$$$$$$$$$) {
> > ) {
> > die "$ds - cloud-init drive is already attached at
> > '$ci_key'\n";
> > }
> > + } elsif ($ds eq 'tpmstate0' && $volume_format && $volume_format
> > ne 'raw') {
> > + die "tpmstate0: volume format is '$volume_format', only
> > 'raw' is supported!\n"
>
> Nit: missing semicolon
>
> checked_parse_volname() always returns a format (valid for QEMU even
> :)), so no need for checking whether it is set
>
thanks, sent a v2!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
