Sorry, of course I only noticed I messed up the references after hitting Send:
On 26/03/2025 11:51, Friedrich Weber wrote: > [...] > > Other places in our stack also use the `http_proxy` datacenter option for > https > connections, e.g. the ones that use proxmox_http::HttpClient with ProxyConfig > such as with the notification system's webhook endpoint. This should have reference [7]. > One argument against this patch is that it breaks backwards compatibility: > Existing setups with `http_proxy` and an *internal* ISO repository from which > they download via https will break. If this is a concern, I'd suggest we wait > for PVE 9 to apply this. > > What do you think? > > FTR, there is some overlap with a patch series by Hannes Laimer [7] but that This should have reference [8]. > one only concerned the `query-url-metadata` and the `apl_download` endpoints > (for downloading appliance templates), not the ISO download. > [1] https://bugzilla.proxmox.com/show_bug.cgi?id=3716 > [2] https://bugzilla.proxmox.com/show_bug.cgi?id=5420#c2 > [3] > https://lore.proxmox.com/pve-devel/20211109141359.990235-1-o.bek...@proxmox.com/ > [4] > https://lore.proxmox.com/pve-devel/42391428-bd80-2d55-5cb6-7c8ecd97a...@proxmox.com/ > [5] https://bugzilla.proxmox.com/show_bug.cgi?id=5420#c0 > [6] > https://lore.proxmox.com/pve-devel/a03631a3-fe78-7f6f-137d-7ee6fdf8f...@proxmox.com/ > [7] > https://git.proxmox.com/?p=proxmox.git;a=blob;f=proxmox-notify/src/endpoints/webhook.rs;h=34dbac5488;hb=7abd2da759d#l266 > [8] > https://lore.proxmox.com/pve-devel/20240308123535.1500-1-h.lai...@proxmox.com/ > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
