On Mon, 03 Mar 2025 10:24:40 +0100, Fiona Ebner wrote: > Changes in v2: > * comment out dead code in BTRFS plugin > * improve commit messages regarding clone > * squash patches 5/6 and 6/6 from v1 > > In list context, the file_size_info() function in Plugin.pm and the > volume_size_info() function in BTRFSPlugin.pm would return 0 for the > size, but in scalar context 1. As reported in the community forum [0], > the change in commit e50dde0 ("volume export: rely on storage plugin's > format"), changing the caller in volume_export() to scalar context > exposed the inconsistency in the return value for the size. This led > to breakage of migration with unsized btrfs subvolumes. > > [...]
Applied, thanks! [1/5] plugin: file size info: be consistent about size of directory subvol commit: 544dc0e893549c62665991b58675fb71f4fe5aac [2/5] btrfs: fix volume size info for subvolumes in scalar context commit: 00105c8003aca8ba6499a4fbdd3803529e4671de [3/5] plugin: volume export formats: avoid superfluous file_size_info() call commit: d97d7ff676dae13ff6dc796103bbc2ef7f32f9e7 [4/5] api: volume info: do not fail for zero-sized subvolumes commit: 0426aa316598f329eacaf80e24638294e746c1be [5/5] btrfs: die early for broken subvolume resize commit: 5a73bac3439261da4b39c6ad22bd32d0ff19b2e6 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel