On 7/14/25 15:49, Christoph Heiss wrote:
Tested the series, came across two thing:
Given e.g. the following interface:
11: ens8: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc [..]
link/ether 01:02:03:04:05:06 brd ff:ff:ff:ff:ff:ff
altname nic8
altname enxdeadff02d073
and the following /etc/network/interfaces snippet:
auto nic8
iface nic8 inet manual
the interface will be displayed twice in the network page. If in the
above snippet s/nic8/ens8/ is done (i.e. using the primary name), it
works correctly.
I guess between our /e/n/i parser and the altname mapping the interface
is picked up twice, so this will need some sort of "de-duplication" in
the backend, from what I can gather.
yeah i don't touch the which interfaces will be shown, so
that's on the /e/n/i parser
---
Further, if an interface has at least two altnames (like above), the
ordering doesn't seem stable across API requests.
E.g. double-click on an interface, close the dialog -> the
altnames will switch around randomly in the table column.
Opening the dialog multiple times yields the same behaviour for the
altname textfield.
yeah that's true, we probably want a 'sort keys' here, i'll wait until
tomorrow for a v2 if there are other remarks
On Mon Jul 14, 2025 at 12:42 PM CEST, Dominik Csapak wrote:
This series goes on top of Stefan Hahnreich's last series[0], but it seems
there is still some things missing from INotify (to e.g. set the altnames via
the api), so maybe the helper I introduce in the pve-manager patch will be
unnecessary, depending if parsing the interfaces file will already return the
altnames.
Note that the pve-manager patch depends on the widget-toolkit patch
0:
https://lore.proxmox.com/pve-devel/20250709194526.560709-2-s.hanre...@proxmox.com/
proxmox-widget-toolkit:
Dominik Csapak (1):
network: optionally show alternative interface names
src/node/NetworkEdit.js | 19 +++++++++++++++++++
src/node/NetworkView.js | 20 ++++++++++++++++++++
2 files changed, 39 insertions(+)
pve-manager:
Dominik Csapak (1):
api/ui: show/return alternative interface names
PVE/API2/Network.pm | 32 ++++++++++++++++++++++++++++++--
www/manager6/node/Config.js | 1 +
2 files changed, 31 insertions(+), 2 deletions(-)
Summary over all repositories:
4 files changed, 70 insertions(+), 2 deletions(-)
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
