Am 29.07.25 um 9:38 AM schrieb Fabian Grünbichler:
> this was copied over from Plugin.pm
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbich...@proxmox.com>

Reviewed-by: Fiona Ebner <f.eb...@proxmox.com>

> ---
>  src/PVE/Storage/LVMPlugin.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm
> index c1f5474..db1be98 100644
> --- a/src/PVE/Storage/LVMPlugin.pm
> +++ b/src/PVE/Storage/LVMPlugin.pm
> @@ -1120,7 +1120,7 @@ sub volume_snapshot_delete {
>          my $parentpath = $snapshots->{$parentsnap}->{file};
>          print
>              "$volname: deleting snapshot '$snap' by rebasing '$childsnap' on 
> top of '$parentsnap'\n";
> -        print "running 'qemu-img rebase -b $parentpath -F qcow -f qcow2 
> $childpath'\n";
> +        print "running 'qemu-img rebase -b $parentpath -F qcow2 -f qcow2 
> $childpath'\n";
>          $cmd = [
>              '/usr/bin/qemu-img',
>              'rebase',

But I'd prefer to join() the command array and print it directly to
avoid such issues altogether.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to