The number of pvedaemon worker processes is currently hardcoded to 3.
This may not be enough for automation-heavy workloads that trigger a
lot of API requests that are synchronously handled by pvedaemon.
Hence, read /etc/default/pvedaemon when starting pvedaemon and allow
overriding the number of workers by specifying MAX_WORKERS in this
file. All other values are only relevant for pveproxy/spiceproxy and
thus ignored.
Signed-off-by: Friedrich Weber <f.we...@proxmox.com>
---
Notes:
I'm not sure if reading /etc/default/pvedaemon, which was not used
until now, is a good solution here, but I decided to go for it because
it seems relatively straightforward and analogous to pveproxy.
Also here, I decided against setting max_workers directly directly in
%daemon_options, to avoid having to call read_proxy_config already
then. If I understand correctly, overriding $self->{max_workers} in
init should be fine because it's only used in PVE::Daemon's
$server_run after init was called.
PVE/Service/pvedaemon.pm | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/PVE/Service/pvedaemon.pm b/PVE/Service/pvedaemon.pm
index 9d7cbc0f..4493f234 100755
--- a/PVE/Service/pvedaemon.pm
+++ b/PVE/Service/pvedaemon.pm
@@ -15,7 +15,7 @@ use base qw(PVE::Daemon);
my $cmdline = [$0, @ARGV];
my %daemon_options = (
- max_workers => 3,
+ max_workers => 3, # may be overridden in init
restart_on_error => 5,
stop_wait_time => 15,
leave_children_open_on_reload => 1,
@@ -26,6 +26,10 @@ my $daemon = __PACKAGE__->new('pvedaemon', $cmdline,
%daemon_options);
sub init {
my ($self) = @_;
+ # all options other than MAX_WORKERS are ignored
+ my $proxyconf = PVE::APIServer::Utils::read_proxy_config($self->{name});
+ $self->{max_workers} = $proxyconf->{MAX_WORKERS} if
$proxyconf->{MAX_WORKERS};
+
my $accept_lock_fn = "/var/lock/pvedaemon.lck";
my $lockfh = IO::File->new(">>${accept_lock_fn}")
--
2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
