Am 29.07.25 um 1:53 PM schrieb Fabian Grünbichler:
> by directly printing the to-be-executed command, instead of copying it which
> is
> error-prone.
>
> Signed-off-by: Fabian Grünbichler <f.gruenbich...@proxmox.com>
> Reviewed-by: Fiona Ebner <f.eb...@proxmox.com>
> ---
>
> Notes:
> v2: join command instead of fixing manually copied message
>
> src/PVE/Storage/Plugin.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
> index 2bd05bd..de41bfe 100644
> --- a/src/PVE/Storage/Plugin.pm
> +++ b/src/PVE/Storage/Plugin.pm
> @@ -1437,7 +1437,6 @@ sub volume_snapshot_delete {
> my $parentpath = $snapshots->{$parentsnap}->{file};
> print
> "$volname: deleting snapshot '$snap' by rebasing
> '$childsnap' on top of '$parentsnap'\n";
> - print "running 'qemu-img rebase -b $parentpath -F qcow -f qcow2
> $childpath'\n";
> $cmd = [
> '/usr/bin/qemu-img',
> 'rebase',
> @@ -1449,6 +1448,7 @@ sub volume_snapshot_delete {
> 'qcow2',
> $childpath,
> ];
> + print "running '", join(' ', $cmd->@*), "'\n";
Style nit: we usually do concatenation with dot, was using commas for
passing a list to print intentional? Same for the next patch.
> eval { run_command($cmd) };
> if ($@) {
> #in case of abort, the state of the snap is still clean,
> just a little bit bigger
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
