On Tue, 29 Jul 2025 14:11:51 +0200, Shannon Sterz wrote:
> zfs itself does not track the refquota per snapshot so we need handle
> this ourselves. otherwise rolling back a volume that has been resize
> since the snapshot, will retain the new size. this is problematic, as
> it means the value in the guest config does not longer match the size
> of the disk on the storage.
>
> this implementation tries to do so by leveraging a user property per
> snapshot.
>
> [...]
Applied, thanks! Fixed up the capitalization in the commit message and
made some minor wording changes.
[1/1] fix #6561: zfspool: track refquota for subvolumes via user properties
commit: a9315a0ed32293d11a56470d2e19598a5212e8e3
> keeping fiona's R-b from v2 as v3 basically just incorporates her
> suggestions (or suggestions she signed off on), but i'd drop the T-b
> as these patches now behave somewhat differently (warning on unknown
> values).
Personally, I prefer if the R-b is dropped if there are non-trivial
changes and that such earlier reviews are rather mentioned as part of
the changelog for context.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
