At this point, the dbus-vmstate helper is not expected to be running
anymore.
Using $noerr here didn't really make sense - as it never should be
running anymore at this point, plus the VM should also be stopped - thus
the "happy" path here is to fail removing the dbus-vmstate helper.
It resulted in another spurious warning _after_ a migration on the
source node.
Fixes: 067a0f55 ("vmstate: improve cleaning up dbus-vmstate and avoid spurious
warning")
Reported-by: Friedrich Weber <f.we...@proxmox.com>
Signed-off-by: Christoph Heiss <c.he...@proxmox.com>
---
src/PVE/QemuServer.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index 30ec58b1..d42e2115 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -6103,7 +6103,8 @@ sub vm_stop_cleanup {
eval {
# ensure that no dbus-vmstate helper is left running in any case
- PVE::QemuServer::DBusVMState::qemu_del_dbus_vmstate($vmid, quiet =>
$noerr);
+ # at this point, it should never be still running, so quiesce any
warnings
+ PVE::QemuServer::DBusVMState::qemu_del_dbus_vmstate($vmid, quiet => 1);
if (!$keepActive) {
my $vollist = get_vm_volumes($conf);
--
2.50.1
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
