On 8/4/25 13:07, Shan Shaji wrote:
In iOS, there was a blue background color visible beneath the bottom
bar, which caused the app to not utilize the full screen height.
Additionally, the colors of the app bar and the status bar
differed when the user began scrolling.

This issue was due to the container color used in the `ColoredSafeArea`
widget, which wrapped the `SafeArea` widget. To fix the issue,
remove the `ColoredSafeArea` and its usages, as all affected screens
already include an `AppBar` widget. Therefore, using a separate
`SafeArea` is not necessary.

Additionaly since the `SafeArea` inside the resource tab and the
task log page is removed as a result the filter sheet was interferring
with the status bar in Android and notch in iOS. To fix the
issue, wrap the drawer content in `SafeArea`.

Signed-off-by: Shan Shaji <s.sh...@proxmox.com>
---

note: Skips running the `dart format` command as there are formatting
changes in the changed files and will be hard to identify the changes
if the files are formatted.

changes since v3:
* Rebase with master.

changes since v2:
* Move dart format related commit message under "---"
* Fix in-consistency of filter sheet on task log widget and
   resource tab. Both filter sheets are now rendered on top
   of App bar.

changes since v1:
* Rebase the changes with master.

  lib/pages/main_layout_slim.dart          | 12 +++++++-----
  lib/widgets/colored_safe_area.dart       | 18 ------------------
  lib/widgets/pve_console_menu_widget.dart |  3 +--
  lib/widgets/pve_lxc_options_widget.dart  |  5 +----
  lib/widgets/pve_lxc_overview.dart        |  5 +----
  lib/widgets/pve_node_overview.dart       |  5 +----
  lib/widgets/pve_qemu_options_widget.dart |  5 +----
  lib/widgets/pve_qemu_overview.dart       |  6 ++----
  lib/widgets/pve_task_log_widget.dart     | 10 ++++------
  9 files changed, 18 insertions(+), 51 deletions(-)
  delete mode 100644 lib/widgets/colored_safe_area.dart



applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to