Am 13.08.25 um 12:08 PM schrieb Fabian Grünbichler:
> On August 13, 2025 10:58 am, Fiona Ebner wrote:
>> @@ -1252,6 +1254,10 @@ sub print_drivedevice_full {
>> if (my $product = $drive->{product}) {
>> $device .= ",product=$product";
>> }
>> +
>> + $has_write_cache = 1;
>
> nit: this already is the default initial value above, and we don't loop
> over devices here? so we could drop this and the comment above
Yes, but since the SCSI branch does modify it in one place, I though it
is more readable and future-proof to be explicit covering both
sub-branches for the device types.
>
>> + } else {
>
> and instead add a comment here that -block and -generic don't support
> this?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
