On 26/08/2025 12:15, Dominik Csapak wrote: > of course, i did not do it for an RFC because i did not expect it to go > in like this without discussion/refining anyway. the next version
That's fine, especially here where it's doesn't changes anything, for things with much change it might be even nice to have a test for an RFC, as then one sees what changes here; but I mostly mentioned the test as a general reminder for everyone, because we all sometimes forget adding one even though it's rather cheap to do so. > will have cfg2command tests (though it does not change anything on > the command line currently, so the tests will just test that the config > is parseable) That's fine for now. We might want to expand cfg2cmd to test more side-effects that should, or should not, happen. That could also be a separate test harness that is just derived from cfg2cmd, to avoid making it overly complex, but just to air out some thoughts, as that is definitively nothing for this series and probably quite a bit more work. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
