The `cronet_http` is throwing `ClientException` [0] instead of `HandShakeException` when the certificate is not valid.
Due to this the exception was directly shown in the UI. Inorder to make the error more user friendly catch the `ClientException` and rethrow `HandShakeException` if the certificate is not valid. [0] - https://github.com/dart-lang/http/blob/ef05b3744424885d93f88a6a50664fb5b7d5cbdb/pkgs/cronet_http/lib/src/cronet_client.dart#L327 Signed-off-by: Shan Shaji <s.sh...@proxmox.com> --- lib/src/authenticate.dart | 31 ++++++++++++++++++++++--------- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/lib/src/authenticate.dart b/lib/src/authenticate.dart index 118408f..a142a4c 100644 --- a/lib/src/authenticate.dart +++ b/lib/src/authenticate.dart @@ -1,5 +1,6 @@ import 'dart:async'; import 'dart:convert'; +import 'dart:io'; import 'package:http/http.dart' as http; import 'package:proxmox_dart_api_client/proxmox_dart_api_client.dart'; @@ -56,6 +57,11 @@ Future<ProxmoxApiClient> authenticate( } on TimeoutException catch (_) { throw ProxmoxApiException( 'Authentication takes unusually long, check network connection', 408); + } on http.ClientException catch (e) { + if (e.message.contains('net::ERR_CERT_AUTHORITY_INVALID')) { + throw HandshakeException(e.message); + } + rethrow; } } @@ -64,14 +70,21 @@ Future<List<PveAccessDomainModel?>> accessDomains( bool validateSSL, { http.Client? httpClient, }) async { - httpClient ??= getCustomIOHttpClient(validateSSL: validateSSL); + try { + httpClient ??= getCustomIOHttpClient(validateSSL: validateSSL); - final path = '/api2/json/access/domains'; - final response = await httpClient - .get(apiBaseUrl.replace(path: path)) - .timeout(Duration(seconds: 25)); - var data = (json.decode(response.body)['data'] as List).map((f) { - return serializers.deserializeWith(PveAccessDomainModel.serializer, f); - }); - return data.toList(); + final path = '/api2/json/access/domains'; + final response = await httpClient + .get(apiBaseUrl.replace(path: path)) + .timeout(Duration(seconds: 25)); + var data = (json.decode(response.body)['data'] as List).map((f) { + return serializers.deserializeWith(PveAccessDomainModel.serializer, f); + }); + return data.toList(); + } on http.ClientException catch (e) { + if (e.message.contains('net::ERR_CERT_AUTHORITY_INVALID')) { + throw HandshakeException(e.message); + } + rethrow; + } } -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
