On Thu, 25 Sep 2025 14:25:07 +0200, Fiona Ebner wrote:
> Changes in v2 (many thanks to Thomas for the discussion!):
> * New approach, return undef instead of caching previous value.
> * Add new patch to improve how 'query-proxmox-support' QMP commands
> are issued.
>
> If disk read/write cannot be queried because of QMP timeout, they
> should not be reported as 0, because a consumer of the RRD stats
> cannot distinguish between 0 being an actual 0 value and 0 being an
> indicator for the absence of the real value. The RRD graphs in the UI
> will already show this correctly.
>
> [...]
Applied, thanks!
btw., while technically correct to have only patch 1/2 marked as v2 as patch
2/2, I'd rather see the versioning per series not per patch, b4 e.g. also gets
confused this way as it cannot find the v2 of patch 2/2.
[1/2] fix #6207: vm status: return undef values when disk{read, write} cannot
be queried
commit: 528df523161aa424cc6dca69230eae1f9a503cef
[2/2] vm status: also queue query-proxmox-support QMP commands
commit: 31d6f5f63bd6edb6c43de3e0213d38199c350cd4
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
