On Wed Sep 24, 2025 at 6:07 PM CEST, Michael Köppl wrote: > This dialog window can be used to create confirmation dialogs with some > amount of customization. It allows adding additional items, optionally > supports confirming intent by entering the ID of the affected guest, > storage, or resource, customizing the buttons of the dialog. > > It is heavily based on the SafeDestroy window, but makes it more > general-purpose, covering both Yes/No dialogs as well as the safe > destroy dialogs with confirmation. > > Signed-off-by: Michael Köppl <m.koe...@proxmox.com> > --- > I settled on adding this window because Ext.Msg.MessageBox is not really > made to be extended, so I chose a similar approach to what was done for > SafeDestroy, extending Ext.window.Window instead. I borrowed heavily > from SafeDestroy, but made the component a bit more > general-purpose/flexible. This component can now be used for yes/no > dialog windows as well as the safe destroy dialogs for guests/storages, > etc. > > I'll also send follow-up patches that use ConfirmRemoveDialog for the > SafeDestroyGuest and SafeDestroyStorage windows in pve-manager.
I think it's a good idea to combine these, but at the same time it's a bit hard to review not seeing the diff from Proxmox.window.SafeDestroy here directly.. I diffed them locally and if it's not too much work, it might be nice to adapt Proxmox.window.SafeDestroy and set dangerous = true there by default and only set dangerous = false for the special case in ConfirmRemoveResource / SafeDestroyResource, but that might also be just nit-picking from my side. What do you think? _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
