On Sat Sep 20, 2025 at 8:20 PM CEST, Thomas Skinner wrote: > Continued work on node maintenance mode button in UI. > > Changes since V1: > - Code refactoring/reformatting > - Clarity in docs > - Remove redundant GET API for maintenance status > - Change button UI to dropdown menu with icons
Sorry for the wait on a review for this.. Thanks for the v2, works as expected and apart from the inline note about the permission it looks good to me. I think it was be better to have a single Enable/Disable toggle button instead of a dropdown if there's no current development to add more maintenance modes to HA LRMs, but I don't want to be nitpicky about this, so with the permission note resolved consider this as: Reviewed-by: Daniel Kral <[email protected]> Tested-by: Daniel Kral <[email protected]> _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
