On Tue Oct 21, 2025 at 4:05 PM CEST, Michael Köppl wrote:
> 1 comment inline
>
> On Tue Oct 14, 2025 at 3:21 PM CEST, Christoph Heiss wrote:
[..]
>> +impl NetworkInterfacePinningOptions {
>> + /// Default prefix to prepend to the pinned interface ID as received
>> from the low-level
>> + /// installer.
>> + pub const DEFAULT_PREFIX: &str = "nic";
>> +
>> + /// Do some basic checks on the options.
>> + ///
>> + /// This checks for:
>> + /// - empty interface names
>> + /// - overlong interface names
>> + /// - duplicate interface names
>
> imo it would make sense to additionally also have the check that the
> interface name is not fully numeric, since according to the docs, this
> is not allowed [0].
>
> [0]
> https://manpages.debian.org/testing/udev/systemd.link.5.en.html#%5BLINK%5D_SECTION_OPTIONS
Good catch, thanks!
I'll add it for v2, in addition to the other restrictions mentioned for
Name= in the man page.
_______________________________________________
pve-devel mailing list
[email protected]
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
