i forgot to add Fionas R-b trailer... sorry!
just holler if i should send a v3 for that...

On 10/29/25 2:13 PM, Dominik Csapak wrote:
due to a timing race condition, it can happen that we try to increase
the 401 count before resetting it (which happens after the first
ticket api call). Since `undefined + ` === NaN, our later check for
`> 5` never triggers and we don't show the login mask, but an empty
window.

To fix this, initialize the variable always with 0.

Observed when restoring a session after a ticket expired while the
browser was closed.

Signed-off-by: Dominik Csapak <[email protected]>
---
changes from v1:
* rebase on master

  www/manager6/Workspace.js | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
index a2574658..60c499cb 100644
--- a/www/manager6/Workspace.js
+++ b/www/manager6/Workspace.js
@@ -13,6 +13,8 @@ Ext.define('PVE.Workspace', {
loginData: null, // Data from last login call + response401count: 0,
+
      onLogin: function (loginData) {
          // override me
      },



_______________________________________________
pve-devel mailing list
[email protected]
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to