Previously, the home screen customization that allows users to change
the light, dark, and tint options was not reflected in the app icon.
This was because no dark mode variant and tint variant was added in
the asset catalogue.

To support dark mode icons, the new App Icon Composer was used to
create icons for light, dark, and tint variants with liquid glass
support. The app icon now adapts dynamically based on the user’s
customization selection. 

For older iOS versions the behavior would be the following:
> If your app supports previous releases (in the Minimum Deployments settings 
> in the 
> target’s General pane) that don’t have the same icon and widget style 
> appearances 
> and Liquid Glass material, Xcode automatically generates app icon images at 
> build 
> time for those releases from the Icon Composer file.

The above qouted paragraph is taken from apple's documentation [1]. Since
the composer file will be used for generating icons i have deleted 
asset catalogue files as well. 

The ticket #6983 [0] has also some other issues that needs to be addressed
which i will be sending as another patch series. 

- [0] https://bugzilla.proxmox.com/show_bug.cgi?id=6983
- [1] 
https://developer.apple.com/documentation/Xcode/creating-your-app-icon-using-icon-composer

Shan Shaji (2):
  fix #6983: ios: allow dark and tint mode icon using icon composer file
  chore: ios: delete asset catalogue files in favor of icon composer
    file

 ios/AppIcon.icon/Assets/dark.svg              |   6 +
 ios/AppIcon.icon/Assets/light.svg             |   6 +
 ios/AppIcon.icon/icon.json                    |  52 ++++++++
 ios/Runner.xcodeproj/project.pbxproj          |  11 +-
 .../AppIcon.appiconset/Contents.json          | 122 ------------------
 .../[email protected]                 | Bin 126022 -> 0 bytes
 .../AppIcon.appiconset/[email protected]  | Bin 692 -> 0 bytes
 .../AppIcon.appiconset/[email protected]  | Bin 2050 -> 0 bytes
 .../AppIcon.appiconset/[email protected]  | Bin 3321 -> 0 bytes
 .../AppIcon.appiconset/[email protected]  | Bin 1425 -> 0 bytes
 .../AppIcon.appiconset/[email protected]  | Bin 3367 -> 0 bytes
 .../AppIcon.appiconset/[email protected]  | Bin 5147 -> 0 bytes
 .../AppIcon.appiconset/[email protected]  | Bin 2050 -> 0 bytes
 .../AppIcon.appiconset/[email protected]  | Bin 4699 -> 0 bytes
 .../AppIcon.appiconset/[email protected]  | Bin 7470 -> 0 bytes
 .../AppIcon.appiconset/[email protected]  | Bin 7470 -> 0 bytes
 .../AppIcon.appiconset/[email protected]  | Bin 11744 -> 0 bytes
 .../AppIcon.appiconset/[email protected]  | Bin 4378 -> 0 bytes
 .../AppIcon.appiconset/[email protected]  | Bin 9529 -> 0 bytes
 .../[email protected]                 | Bin 1418 -> 0 bytes
 20 files changed, 73 insertions(+), 124 deletions(-)
 create mode 100644 ios/AppIcon.icon/Assets/dark.svg
 create mode 100644 ios/AppIcon.icon/Assets/light.svg
 create mode 100644 ios/AppIcon.icon/icon.json
 delete mode 100644 ios/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json
 delete mode 100644 
ios/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
 delete mode 100644 
ios/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
 delete mode 100644 
ios/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
 delete mode 100644 
ios/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
 delete mode 100644 
ios/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
 delete mode 100644 
ios/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
 delete mode 100644 
ios/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
 delete mode 100644 
ios/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
 delete mode 100644 
ios/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
 delete mode 100644 
ios/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
 delete mode 100644 
ios/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
 delete mode 100644 
ios/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
 delete mode 100644 
ios/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
 delete mode 100644 
ios/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]
 delete mode 100644 
ios/Runner/Assets.xcassets/AppIcon.appiconset/[email protected]

-- 
2.50.1



_______________________________________________
pve-devel mailing list
[email protected]
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to