Some small followups for the initial name pinning support [0]. First and foremost makes the interface name checks a bit stricter, to comply with our `pve-iface` schema - as reported by Stoiko [1]. Thanks!
Patch #4 & #5 exclude non-physical interfaces from being shown in the pinning dialog in the GUI and TUI, respectively. While this does change anything for normal bare-metal installation, it is a) a bit of future-proofing and b) improves developer/testing experience a bit, as these interfaces should never be available for pinning anyway. [0] https://lore.proxmox.com/pve-devel/[email protected]/ [1] https://lore.proxmox.com/pve-devel/[email protected]/ Diffstat ======== Christoph Heiss (6): sys: net: pinning: make interface name checks stricter common: pinning: make interface name checks stricter test: validate-link-pin-map: give all tests a name gui: network: only display pinnable devices in pinning options dialog tui: network: only display pinnable devices in pinning options dialog tree-wide: run cargo fmt Proxmox/Install.pm | 9 +-- Proxmox/Install/RunEnv.pm | 12 ++- Proxmox/Sys/Net.pm | 35 +++------ proxinstall | 13 +++- .../src/bin/proxmox-auto-installer.rs | 7 +- proxmox-auto-installer/src/utils.rs | 15 ++-- .../src/fetch_plugins/http.rs | 7 +- .../src/fetch_plugins/partition.rs | 7 +- proxmox-installer-common/src/lib.rs | 7 +- proxmox-installer-common/src/options.rs | 77 ++++++++++++++----- proxmox-installer-common/src/setup.rs | 33 ++++---- proxmox-tui-installer/src/main.rs | 7 +- proxmox-tui-installer/src/views/network.rs | 33 +++++--- test/validate-link-pin-map.pl | 34 ++++++-- 14 files changed, 189 insertions(+), 107 deletions(-) -- 2.51.0 _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
