Fix #6816: Prevent ceph-exporter Daemon from Crashing on Startup - v3 =====================================================================
tl;dr: Stop ceph-exporter.service from ending up in a crash loop by handing it a custom keyring file and setting its group to `www-data`, similar to what we did for ceph-crash.service [0] before. v2 contains the entire description; see below for a link. Changes ------- The only notable change from v2 is that the race condition @Maximiliano found [1] (thanks!) is now removed—after a quick discussion with @Stoiko (thanks!), it was deemed that it's best to let admins restart `ceph-exporter` themselves instead of automagically resetting its failure state and restarting it in debian/postinst of pve-manager. The main reasoning behind this is that unlike the crash daemon, the exporter isn't a critical part of Ceph, and moreover, *nobody* upstream (according to https://codesearch.debian.net) is calling `systemctl reset-failed <UNIT>` in postinst. (Determined by searching for `reset-failed`, without backticks ofc). A quick smoke test here would be much appreciated. NOTE ---- Patch #03 adds a call to a new helper in debian/postinst. The version check there should be adapted after / while applying the series. Right now, the version in the check is set to `9.1.5`. Previous Versions ----------------- v1: https://lore.proxmox.com/pve-devel/[email protected]/ v2: https://lore.proxmox.com/pve-devel/[email protected]/ References ---------- [0]: https://lore.proxmox.com/pve-devel/[email protected]/ [1]: https://lore.proxmox.com/pve-devel/[email protected]/ Summary of Changes ------------------ pve-manager: Max R. Carrara (5): ceph: tools: add helper sub for creating or updating keyring files fix #6816: api: ceph: create 'client.exporter' w/ keyring fix #6816: bin: add pve-ceph-keyring helper and call it in postinst ceph: tools: simplify helper sub for crash keyring file bin: make pve-init-ceph-crash call pve-ceph-keyring PVE/API2/Ceph/MON.pm | 9 ++ PVE/Ceph/Tools.pm | 108 ++++++++++++--- bin/Makefile | 1 + bin/pve-ceph-keyring | 286 ++++++++++++++++++++++++++++++++++++++++ bin/pve-init-ceph-crash | 152 +-------------------- debian/postinst | 6 + 6 files changed, 397 insertions(+), 165 deletions(-) create mode 100755 bin/pve-ceph-keyring ceph: Max R. Carrara (1): fix #6816: patches: make ceph-exporter use custom keyring ...orter-use-custom-keyring-and-set-gro.patch | 32 +++++++++++++++++++ patches/series | 1 + 2 files changed, 33 insertions(+) create mode 100644 patches/0042-systemd-ceph-exporter-use-custom-keyring-and-set-gro.patch -- 2.47.3 _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
