Am 08.01.26 um 4:20 PM schrieb Dominik Csapak: > 2 high level notes (but not blocker): > > * would it maybe make sense to pull the 'get_current_qemu_machine' out > so other parts of the api/code can reuse that? > i guess we'll maybe have more of such checks in the future, and having > the version already available at e.g. the top level of the api call > could make sense. This can ofc also be done when we actually need it
Can easily be done when another user shows up. > * afaics the checks in QemuMigrate and the api are identical, would > it make sense to factor them out, so they don't accidentally > diverge? (Are there maybe even more places where we check this?) I didn't see any other places and the check is very unlikely to change in the future and two times two lines is really not much, so I applied it as-is with your R-B, thanks! > Aside from these (minor) changes consider this: > > Reviewed-by: Dominik Csapak <[email protected]> _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
