On Thu, Jan 29, 2026 at 06:38:50PM +0100, Thomas Lamprecht wrote: > Am 21.01.26 um 11:34 schrieb Arthur Bied-Charreton: > > Add explicit length checks to ID validation functions to provide clearer > > error messages in case of length mismatches > > A few of these checks might be also done by setting the "maxLength" and/or the > "minLength" property in the matching "register_standard_option" schema > definition. > Could you check that? Would be IMO better to reuse the schema capabillities, > and > that way, this limits would be also visible in the api schema directly. > > Hey Thomas, thanks for the feedback, I did not think about that.
After looking into this, it seems like we could get rid of most of the parse_*_id functions (and probably others as well), but this would require changing PVE::JSONSchema::check_format to check in the following order: `length -> pattern -> custom format fn` as opposed to currently: `custom format fn -> pattern -> length` In the JSON Schema validation's current implementation, the length parameters are effectively ignored due to the pattern/format function being checked beforehand. Do you see any issue with changing the validation order?
