Thanks for the patch (I run into this regularly myself...)! Some comments on the subject:
- if I'm not mistaken it's a bit too long [1] - the repo should be "manager", should "container" - I'd split networkedit into two words: "network edit" - I'd suggest to have "ui:" for frontend changes somewhere (pve-manager also contains backend code) - And "fix #4911:" should be moved to the beginning [1] And on the commit message: In general, the line-length should be at most 72 characters [1]. On 09/02/2026 16:48, Lukas Sichert wrote: > Currently, when creating an active-backup bond, it is not possible to leave > the primary-bond field blank, even though this value is optional in the > backend. > If no value is currently set in the frontend, it sends the value '' to the > backend. There, it is interpreted as the name of an interface, which is > incorrect, and therefore the error 'bond-primary: invalid format - invalid > network interface name '' ' is displayed. > Changing the field type to 'proxmoxtextfield' will prevent the empty string > from being sent due to the way we submit the data [...] If possible, "we" should be avoided in comment messages [1]. Also, it might be nice to be a bit more precise in which sense proxmoxtextfield sends the data differently. > Addtionally, the deleteEmpty flag is set, so that devices, that were unset, > will be deleted by the backend. typo: Additionally > > Signed-off-by: Lukas Sichert <[email protected]> > --- > src/node/NetworkEdit.js | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/node/NetworkEdit.js b/src/node/NetworkEdit.js > index 39c7e35..c945139 100644 > --- a/src/node/NetworkEdit.js > +++ b/src/node/NetworkEdit.js > @@ -239,10 +239,11 @@ Ext.define('Proxmox.node.NetworkEdit', { > disabled: true, > }); > > - let primaryfield = Ext.createWidget('textfield', { > + let primaryfield = Ext.createWidget('proxmoxtextfield', { > fieldLabel: 'bond-primary', > name: 'bond-primary', > value: '', > + deleteEmpty: !me.isCreate, > disabled: true, > }); > [1] https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages
