I prefer this one over v1 because I think it's more comprehensible. lgtm Reviewed-by: Michael Köppl <[email protected]>
On Tue Mar 3, 2026 at 2:22 PM CET, Maximiliano Sandoval wrote: > When read next to `max_relocate` it is not clear which happens first > after a service fails to start. > > Signed-off-by: Maximiliano Sandoval <[email protected]> > > --- > > Differences from v1: > - Incorporate feedback. Namely, "the service will be attempted to be > relocated" > was a bit too convoluted. > > src/PVE/HA/Resources.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/HA/Resources.pm b/src/PVE/HA/Resources.pm > index 68d9d16..404f6dc 100644 > --- a/src/PVE/HA/Resources.pm > +++ b/src/PVE/HA/Resources.pm > @@ -73,7 +73,8 @@ EODESC > }, > max_restart => { > description => "Maximal number of tries to restart the service > on" > - . " a node after its start failed.", > + . " a node after its start failed. When reached, the HA > manager will try to" > + . " relocate the service to an eligible node.", > type => 'integer', > optional => 1, > default => 1,
