On Thu Mar 12, 2026 at 9:10 AM CET, Thomas Lamprecht wrote: > Am 12.03.26 um 08:15 schrieb Dominik Rusovac: >> Signed-off-by: Dominik Rusovac <[email protected]> >> --- >> src/PVE/HA/LRM.pm | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/src/PVE/HA/LRM.pm b/src/PVE/HA/LRM.pm >> index e4b0ec8..09a965c 100644 >> --- a/src/PVE/HA/LRM.pm >> +++ b/src/PVE/HA/LRM.pm > >> - $haenv->log('err', "node need to be fenced - releasing >> agent_lock\n"); >> + $haenv->log('err', "node needs to be fenced - releasing >> agent_lock\n"); > >> - "node need to be fenced during maintenance mode - releasing >> agent_lock\n", >> + "node needs to be fenced during maintenance mode - >> releasing agent_lock\n", > >> - "get shutdown request in state 'lost_agent_lock' - " >> + "got shutdown request in state 'lost_agent_lock' - " >> . "detected $service_count running services", >> ); >> > > The fixes themselves look OK, but they all touch the log output that is > also used for regression tests, and with that come two options: > 1. either it doesn't matter because no test covers these logs, which > would be rather bad on itself. > 2. or, more likely, you forgot to check in the test changes required, > potentially not running the harness before sending this out. > > Here it's 2., a running `make -C src/` test or building the whole package > will result in a failure to do so. > > As we do not have a million of test cases and each is relatively small > line count, the churn should not be to big to send it along. > Please assemble a v2 doing so and ensure to run the the testsuite(s) > before sending any patch, a deb package build normally should do > the trick here.
Indeed, I didn't check in the required test changes. My bad, sorry. Superseded-by v2: https://lore.proxmox.com/all/[email protected]/T/
