Thomas Lamprecht <[email protected]> writes: > Am 13.03.26 um 10:55 schrieb Maximiliano Sandoval: >> We re-use the same components from the 'freeze-fs-on-backup' checkbox >> but without referencing that this only affects backups. >> >> Signed-off-by: Maximiliano Sandoval <[email protected]> >> --- >> www/manager6/form/AgentFeatureSelector.js | 30 +++++++++++++++++++++++ >> 1 file changed, 30 insertions(+) >> >> diff --git a/www/manager6/form/AgentFeatureSelector.js >> b/www/manager6/form/AgentFeatureSelector.js >> index b64837b7..36e5bd8a 100644 >> --- a/www/manager6/form/AgentFeatureSelector.js >> +++ b/www/manager6/form/AgentFeatureSelector.js >> @@ -21,6 +21,30 @@ Ext.define('PVE.form.AgentFeatureSelector', { >> }, >> disabled: true, >> }, >> + { >> + xtype: 'proxmoxcheckbox', >> + boxLabel: gettext( >> + 'Freeze/thaw guest filesystems during certain operations >> for consistency', >> + ), >> + name: 'guest-fsfreeze', >> + reference: 'guest_fsfreeze', >> + bind: { >> + disabled: '{!enabled.checked}', >> + }, >> + disabled: true, >> + uncheckedValue: '0', >> + defaultValue: '1', >> + }, >> + { >> + xtype: 'displayfield', >> + userCls: 'pmx-hint', >> + value: gettext( >> + 'Freeze/thaw for guest filesystems disabled. This can lead >> to inconsistent disk images after performing certain operations.', > > very ambiguous wording - what operations? Commit message doesn't give > any hints either. Is there at least a docs change for users to learn > what actual operations this will happen?
The modes are documented at [pve-admin] which is right after where the "Help" button in the dialog points to, however, the online documentation has not been updated to contain [docs#862cd43b0]. Given that it is five operation, some with conditionals, I opted to not give a full explanation here. [pve-admin] https://pve.proxmox.com/pve-docs/pve-admin-guide.html#qm_qga_fsfreeze [docs#862cd43b0] https://git.proxmox.com/?p=pve-docs.git;a=commitdiff;h=862cd43b09245de212332bc3b9b03dae0de7ccb8 > btw. this series could have been like three, maybe four commits, > some semantic separation is good, but not every tiny clean-up is > a dedicated semantic change. > >> + ), >> + bind: { >> + hidden: '{guest_fsfreeze.checked}', >> + }, >> + }, >> { >> xtype: 'displayfield', >> userCls: 'pmx-hint', >> @@ -75,6 +99,9 @@ Ext.define('PVE.form.AgentFeatureSelector', { >> if (PVE.Parser.parseBoolean(values['freeze-fs-on-backup'])) { >> delete values['freeze-fs-on-backup']; >> } >> + if (PVE.Parser.parseBoolean(values['guest-fsfreeze'])) { >> + delete values['guest-fsfreeze']; >> + } >> >> const agentstr = PVE.Parser.printPropertyString(values, 'enabled'); >> return { agent: agentstr }; >> @@ -85,6 +112,9 @@ Ext.define('PVE.form.AgentFeatureSelector', { >> if (!Ext.isDefined(res['freeze-fs-on-backup'])) { >> res['freeze-fs-on-backup'] = 1; >> } >> + if (!Ext.isDefined(res['guest-fsfreeze'])) { >> + res['guest-fsfreeze'] = 1; >> + } >> >> this.callParent([res]); >> }, -- Maximiliano
