The qemu_min_version() helper is only used for the USB port limit
right now. The implementation was wrong, as it wrongly required the
minor version (or micro version if there were such a caller) to be
greater or equal too, even if the major version is already greater.

Reported by a user in the forum:
[0]: https://forum.proxmox.com/threads/26551/post-855326

Fixes: 17dcba38 ("ui: qemu: increase available usb ports depending on machine 
and ostype")
Signed-off-by: Fiona Ebner <[email protected]>
---
 www/manager6/Utils.js | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 2ed4e65d..bbf59d8f 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -1808,6 +1808,9 @@ Ext.define('PVE.Utils', {
         qemu_min_version: function (toCheck, minVersion) {
             let i;
             for (i = 0; i < toCheck.length && i < minVersion.length; i++) {
+                if (toCheck[i] > minVersion[i]) {
+                    return true;
+                }
                 if (toCheck[i] < minVersion[i]) {
                     return false;
                 }
-- 
2.47.3




Reply via email to