... by sourcing CPU flags from qom-list-properties. The recognized-CPUID-flags-x86_64 list was generated from QEMU's '-cpu help' output, which does not advertise Hyper-V enlightenments. Source the flags from the qom-list-properties QMP command instead to include them.
The properties are queried from the max-x86_64-cpu CPU type, which is also available on aarch64 (as opposed to host-x86_64-cpu). The CPU typename is passed to the script as a CLI argument to allow easily extending it to query flags for other architectures. The following unwanted properties are filtered out: * Non-boolean properties, since the custom CPU models config only supports enable/disable. * Properties exposed by qom-list-properties that are neither CPUID flags nor Hyper-V enlightenments. * The 'hv-syndbg' Hyper-V enlightenment, which depends on whether KVM is available at build time and would therefore lead to inconsistent results. [0] [0] https://lore.proxmox.com/pve-devel/[email protected]/ Suggested-by: Fiona Ebner <[email protected]> Signed-off-by: Arthur Bied-Charreton <[email protected]> --- debian/parse-cpu-flags.pl | 144 ++++++++++++++++++++++++++++++++++---- debian/rules | 2 +- 2 files changed, 130 insertions(+), 16 deletions(-) diff --git a/debian/parse-cpu-flags.pl b/debian/parse-cpu-flags.pl index 1847b3e..e680f99 100755 --- a/debian/parse-cpu-flags.pl +++ b/debian/parse-cpu-flags.pl @@ -1,23 +1,137 @@ #!/usr/bin/perl -use warnings; -use strict; +use v5.36; -my @flags = (); -my $got_flags_section; +use IPC::Open2; +use JSON; -while (<STDIN>) { - if (/^\s*Recognized CPUID flags:/) { - $got_flags_section = 1; - next; - } - next if !$got_flags_section; +# qemu/target/i386/cpu.c, x86_cpu_initfn() +my $qemu_cpu_flag_alias_map = { + cmp_legacy => 'cmp-legacy', + ds_cpl => 'ds-cpl', + ffxsr => 'fxsr-opt', + fxsr_opt => 'fxsr-opt', + 'hv-apicv' => 'hv-avic', + i64 => 'lm', + kvm_nopiodelay => 'kvm-nopiodelay', + kvm_mmu => 'kvm-mmu', + kvm_asyncpf => 'kvm-asyncpf', + kvm_asyncpf_int => 'kvm-asyncpf-int', + kvm_steal_time => 'kvm-steal-time', + kvm_pv_eoi => 'kvm-pv-eoi', + kvm_pv_unhalt => 'kvm-pv-unhalt', + kvm_poll_control => 'kvm-poll-control', + lahf_lm => 'lahf-lm', + lbr_fmt => 'lbr-fmt', + nodeid_msr => 'nodeid-msr', + nrip_save => 'nrip-save', + pause_filter => 'pause-filter', + pclmuldq => 'pclmulqdq', + perfctr_core => 'perfctr-core', + perfctr_nb => 'perfctr-nb', + sse3 => 'pni', + sse4_1 => 'sse4.1', + sse4_2 => 'sse4.2', + 'sse4-1' => 'sse4.1', + 'sse4-2' => 'sse4.2', + svm_lock => 'svm-lock', + tsc_adjust => 'tsc-adjust', + tsc_scale => 'tsc-scale', + vmcb_clean => 'vmcb-clean', + xd => 'nx', +}; - s/^\s+//; +# Static blacklist to be reviewed on QEMU bumps. +# +# Currently includes boolean properties from qom-list-properties that are neither CPUID +# flags ('-cpu help') nor Hyper-V enlightenments ('hv-*'). Entries excluded for other +# reasons are annotated inline. +my $filtered_props = { + 'max-x86_64-cpu' => { + check => 1, + 'cpuid-0xb' => 1, + enforce => 1, + 'fill-mtrr-mask' => 1, + 'host-cache-info' => 1, + 'host-phys-bits' => 1, + hotpluggable => 1, + hotplugged => 1, + # Presence varies at built-time based on whether KVM is present (CONFIG_SYNDBG) + # https://lore.proxmox.com/pve-devel/[email protected]/ + 'hv-syndbg' => 1, + kvm => 1, + 'kvm-pv-enforce-cpuid' => 1, + 'l3-cache' => 1, + 'legacy-cache' => 1, + 'legacy-multi-node' => 1, + lmce => 1, + migratable => 1, + pmu => 1, + realized => 1, + 'start-powered-off' => 1, + 'tcg-cpuid' => 1, + 'vmware-cpuid-freq' => 1, + 'x-amd-topoext-features-only' => 1, + 'x-arch-cap-always-on' => 1, + 'x-consistent-cache' => 1, + 'x-force-cpuid-0x1f' => 1, + 'x-force-features' => 1, + 'x-l1-cache-per-thread' => 1, + 'x-migrate-error-code' => 1, + 'x-migrate-smi-count' => 1, + 'x-pdcm-on-even-without-pmu' => 1, + 'x-vendor-cpuid-only' => 1, + 'x-vendor-cpuid-only-v2' => 1, + 'xen-vapic' => 1, + }, +}; - push @flags, split(/\s+/); -} +sub print_flags($qemu_bin, $typename) { + die "Unknown typename, must be one of '" . join("', '", keys $filtered_props->%*) . "'\n" + if !defined($filtered_props->{$typename}); + + my $pid = open2( + my $out, + my $in, + $qemu_bin, + '-machine', + 'none', + '-display', + 'none', + '-S', + '-qmp', + 'stdio', + '-nodefaults', + ); + + my $qmp = sub ($cmd, %args) { + print $in encode_json({ execute => $cmd, %args ? (arguments => \%args) : () }), "\n"; + while (my $line = <$out>) { + my $msg = decode_json($line); + next if $msg->{event}; + return $msg->{return} if exists($msg->{return}); + die "QMP error: " . encode_json($msg->{error}) if $msg->{error}; + } + }; -die "no QEMU/KVM CPU flags detected from STDIN input" if scalar (@flags) <= 0; + my $flags = {}; + my $greeting = <$out>; + my $decoded_greeting = decode_json($greeting); + die "Unexpected QMP greeting: $greeting\n" if !exists($decoded_greeting->{QMP}); + + $qmp->('qmp_capabilities'); + my $props = $qmp->('qom-list-properties', typename => $typename); + for my $qo ($props->@*) { + next if $qo->{type} ne 'bool' || defined($filtered_props->{$typename}->{$qo->{name}}); + my $resolved_name = $qemu_cpu_flag_alias_map->{$qo->{name}} // $qo->{name}; + $flags->{$resolved_name} = 1; + } + $qmp->('quit'); + waitpid($pid, 0); + + my @flags = sort keys $flags->%*; + print join("\n", @flags) . "\n"; +} -print join("\n", @flags) or die "$!\n"; +my ($qemu_bin, $typename) = @ARGV; +print_flags($qemu_bin, $typename); diff --git a/debian/rules b/debian/rules index c90db29..053f2f3 100755 --- a/debian/rules +++ b/debian/rules @@ -123,7 +123,7 @@ install: build rm -f $(destdir)/usr/lib/kvm/virtfs-proxy-helper # CPU flags are static for QEMU version, allows avoiding more costly checks - $(destdir)/usr/bin/qemu-system-x86_64 -cpu help | ./debian/parse-cpu-flags.pl > $(flagfile) + ./debian/parse-cpu-flags.pl $(destdir)/usr/bin/qemu-system-x86_64 max-x86_64-cpu > $(flagfile) # Supported machine versions are static for a given QEMU binary. $(destdir)/usr/bin/qemu-system-x86_64 -machine help | ./debian/parse-machines.pl > $(machine_file_x86_64) -- 2.47.3
