my $updatefn = sub {
my $conf = PVE::QemuServer::load_config($vmid);
PVE::QemuServer::check_lock($conf);
die "you can't convert a template to a template"
if PVE::QemuServer::is_template($conf) && !$disk;
my $realcmd = sub {
PVE::QemuServer::template_create($vmid, $conf, $disk);
};
return $rpcenv->fork_worker('qmtemplate', $vmid, $authuser,
$realcmd);
PVE::QemuServer::update_config_nolock($vmid, $conf, 1);
};
The PVE::QemuServer::update_config_nolock($vmid, $conf, 1); get's never
executed here in Qemu.pm
As we have a return before.
Stefan
Am 16.04.2013 13:28, schrieb Stefan Priebe - Profihost AG:
> This template has no disk. And the Name base- was chosen by me while
> creating the VM. I didn't know that i'm not allowed to choose this name
> for a normal VM. Bug?
>
> Stefan
>
> Am 16.04.2013 13:25, schrieb Alexandre DERUMIER:
>> "base-template-test" seem to be a non standard proxmox disk name...
>>
>> (should be base-166-disk-1)
>>
>>
>> ----- Mail original -----
>>
>> De: "Stefan Priebe - Profihost AG" <s.pri...@profihost.ag>
>> À: "Alexandre DERUMIER" <aderum...@odiso.com>
>> Cc: pve-devel@pve.proxmox.com, "Dietmar Maurer" <diet...@proxmox.com>
>> Envoyé: Mardi 16 Avril 2013 13:20:13
>> Objet: Re: [pve-devel] Feature HW Profiles
>>
>> Nothing happens:
>>
>> [ ~]# cat /etc/pve/qemu-server/166.conf
>> bootdisk: scsi0
>> cores: 2
>> localtime: 1
>> memory: 4096
>> name: base-template-test
>> net0: virtio=4A:2B:B0:82:F9:2A,bridge=vmbr0,rate=12.5
>> onboot: 1
>> ostype: l26
>> scsihw: virtio-scsi-pci
>> sockets: 1
>> [ ~]# qm template 166
>> [ ~]# cat /etc/pve/qemu-server/166.conf
>> bootdisk: scsi0
>> cores: 2
>> localtime: 1
>> memory: 4096
>> name: base-template-test
>> net0: virtio=4A:2B:B0:82:F9:2A,bridge=vmbr0,rate=12.5
>> onboot: 1
>> ostype: l26
>> scsihw: virtio-scsi-pci
>> sockets: 1
>>
>>> Am 16.04.2013 12:28, schrieb Alexandre DERUMIER:
>>>>>> Then i'll wait until these patches get integrated. Right now qemu-img
>>>>>> segfaults with rbd for me when trying to clone.
>>>>
>>>> Could you describe the problem ? I have tested it last month and it was
>>>> working fine.
>>>>
>>>> (Just to be sure, you don't try to use qemu-img on a running vm, because
>>>> it don't work)
>>>>
>>>> ----- Mail original -----
>>>>
>>>> De: "Stefan Priebe - Profihost AG" <s.pri...@profihost.ag>
>>>> À: "Dietmar Maurer" <diet...@proxmox.com>
>>>> Cc: pve-devel@pve.proxmox.com
>>>> Envoyé: Mardi 16 Avril 2013 11:04:39
>>>> Objet: Re: [pve-devel] Feature HW Profiles
>>>>
>>>> Hi,
>>>> Am 16.04.2013 10:58, schrieb Dietmar Maurer:
>>>>>>> VM templates will provide a way to do that (patches from Alexandre).
>>>>>>
>>>>>> Yes and no as the disk will be also cloned. I'm just speaking about the
>>>>>> settings
>>>>>> like in OpenStack, OpenNebula and others.
>>>>>
>>>>> We can also allow to create templates without any disks. You can then add
>>>>> the disks when you clone.
>>>>
>>>> oh OK sorry.
>>>>
>>>> Then i'll wait until these patches get integrated. Right now qemu-img
>>>> segfaults with rbd for me when trying to clone.
>>>>
>>>> Thanks!
>>>>
>>>> Greets Stefan
>>>>
>>>>
>>>> _______________________________________________
>>>> pve-devel mailing list
>>>> pve-devel@pve.proxmox.com
>>>> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>>>>
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
