>>Would be great if you can track this down. What do you mean ? implement some debug messages to see which functions are called on manual cancel ?
if yes, no problem, I'll do it today. ----- Mail original ----- De: "Dietmar Maurer" <diet...@proxmox.com> À: "Alexandre DERUMIER" <aderum...@odiso.com> Cc: pve-devel@pve.proxmox.com Envoyé: Jeudi 20 Novembre 2014 07:21:37 Objet: RE: [pve-devel] bug ? vmstate state snapshot file not closed on cancel > >>This is now done by a ref counting schema: > >> > >>bdrv_unref(snap_state.bs); > > Yes, I see it in save_snapshot_cleanup(). > > which is used in save_snapshot_error() and save_snapshot_completed(). > > > But it seem that when you manually abort the task, it's never called. > > we call qmp savevm-end if we catch the error, but the save_snapshot_cleanup > in > not in savevm-end. Would be great if you can track this down. _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel