> > > - my $path = $class->path($scfg, $volname); > > > + die "illegal name '$name' - should be 'vm-*-*'\n" > > > + if $name !~ m/^vm-\d+-/; > > > > > > And reason for above check? Or did you just copied that code from > > > alloc_image? > > Right. And that's why I changed the name - to keep it the same. > > Is that a bad approach? > > I just think you don't need to verify the name here. Okay.
> > I'm aware that this makes my patch not overly useful; I wanted to have > > a small first patch, so that I can see the coding conventions. > > Makes sense. But I will not apply the patch until those bugs are fixed. Fair enough. _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
