This way, the whole eval{} statement makes no sense anymore?!

sub run_replication {
    my ($guest_class, $jobcfg, $iteration, $start_time, $logfunc, $noerr,
$verbose) = @_;

    my $timeout = 2; # do not wait too long - we repeat periodically anyways
    return PVE::GuestHelpers::guest_migration_lock(
            $jobcfg->{guest}, $timeout, $run_replication_nolock,
            $guest_class, $jobcfg, $iteration, $start_time, $logfunc, $noerr,
$verbose);
}


> @@ -380,10 +374,9 @@ sub run_replication {
>       my $timeout = 2; # do not wait too long - we repeat periodically anyways
>       $volumes = PVE::GuestHelpers::guest_migration_lock(
>           $jobcfg->{guest}, $timeout, $run_replication_nolock,
> -         $guest_class, $jobcfg, $iteration, $start_time, $logfunc, $noerr,
> $verbose);
> +         $guest_class, $jobcfg, $iteration, $start_time, $logfunc, $verbose);
>      };
>      if (my $err = $@) {
> -     return undef if $noerr;
>       die $err;
>      }
>      return $volumes;

_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to