We checked if a specific error was set or, respectively, not set to
know if we got the lock or not.
The check if we may unlock again was negated and thus could lead to
problems, in specific - rather unlikely - cases.
Use the by the previous patch added $got_lock variable, which only
gets set when we really got the lock, instead.
While refactoring for the new variable, set the $noerr parameter of
check_cfs_quorum() as we do not want to die here.
---
was 1/3 in v2
data/PVE/Cluster.pm | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm
index 968ad4b..98a8cc3 100644
--- a/data/PVE/Cluster.pm
+++ b/data/PVE/Cluster.pm
@@ -916,14 +916,9 @@ my $cfs_lock = sub {
alarm(0);
- if ($err && ($err eq "got lock request timeout\n") &&
- !check_cfs_quorum()){
- $err = "$msg: no quorum!\n";
- }
+ $err = "$msg: no quorum!\n" if !$got_lock && !check_cfs_quorum(1);
- if (!$err || $err !~ /^got lock timeout -/) {
- rmdir $filename; # cfs unlock
- }
+ rmdir $filename if $got_lock; # if we held the lock always unlock again
if ($err) {
$@ = $err;
--
2.11.0
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
