Would be nice to get a warning in the (task) log if QGA is configured
but it's not running, IMO. So the user sees that he forgot to setup
QGA entirely or it seems that it does not runs anymore in the VM.
Looks good, besides that.
i know it is not clear from the patch,
but qga_check_running does this already
sub qga_check_running {
my ($vmid) = @_;
eval { vm_mon_cmd($vmid, "guest-ping", timeout => 3); };
if ($@) {
warn "Qemu Guest Agent are not running - $@";
return 0;
}
return 1;
}
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
