Hi,

On Tue, Mar 13 2018 10:25:47 +0100, Thomas Lamprecht wrote:
> What Fabian meant with:
> > [...] our API has a timeout per request, [...]
> 
> is that our API already has 30 seconds as timeout for response,
> so using 30 seconds here can be problematic.
> 
> As a quick easy improvement we could probably increase it from
> 5 to say 20-25 seconds, still below the API timeout, but nonetheless
> multiple times higher than now.

Now that the CLA stuff is out of the way, here's a diff to do that then.
>From e32d75e16eace67454bae3637f2cc8e68b32d7c1 Mon Sep 17 00:00:00 2001
From: Lauri Tirkkonen <la...@tuxera.com>
Date: Mon, 12 Mar 2018 16:00:01 +0200
Subject: [PATCH] increase zfs default timeout to 20sec

the zfs default txg commit is every 5 seconds, so on busy pools things
can take more than that quite easily.

Signed-off-by: Lauri Tirkkonen <la...@tuxera.com>
---
 PVE/Storage/ZFSPoolPlugin.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/Storage/ZFSPoolPlugin.pm b/PVE/Storage/ZFSPoolPlugin.pm
index e864a58..09f6a92 100644
--- a/PVE/Storage/ZFSPoolPlugin.pm
+++ b/PVE/Storage/ZFSPoolPlugin.pm
@@ -167,7 +167,7 @@ sub path {
 sub zfs_request {
     my ($class, $scfg, $timeout, $method, @params) = @_;
 
-    my $default_timeout = PVE::RPCEnvironment->is_worker() ? 60*60 : 5;
+    my $default_timeout = PVE::RPCEnvironment->is_worker() ? 60*60 : 20;
 
     my $cmd = [];
 
-- 
2.16.2

_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to